fix(dashboard): Remove 308 redirect when creating new dashboards

[ericsong]

SUMMARY

Currently, a request for a new dashboard (hitting /dashboard/new) will respond with a 308 permanent redirect because the UI hits /dashboard/new even though the backend exposes /dashboard/new/

superset/superset/views/dashboard/views.py

Line 117 in 6575cac

@expose("/new/")

Flask handles this case by responding with a 308 to the exposed version https://flask-cn.readthedocs.io/en/stable/api/#flask.Flask.route.

This PR changes routes in the frontend from /dashboard/new to /dashboard/new/ so that requests can be made without a 308 redirect.

In our infrastructure setup, there's a problem with the 308 redirect and it points to an invalid address. I believe others have seen this problem as well in this issue #20577.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Reproduction Steps

1. Hard refresh to remove cached response to /dashboard/new redirection
2. Create a new dashboard

Before

After

TESTING INSTRUCTIONS

See Reproduction Steps in section above

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[github-actions]

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

[ericsong]

Alternatively, we could change the backend

superset/superset/views/dashboard/views.py

Line 117 in 6575cac

@expose("/new/")

to expose /new instead of /new/ and I think that would work too.

[ericsong]

hey! @rusackas @dpgaspar

just wanted to follow up on this

[mmpepin]

Hello @rusackas @dpgaspar. We have the same issue on version 4.0. Is there anything planned to fix this? Thanks!

[fatoujap]

Hello everyone, I would like to know if this PR has been reviewed or if an alternative solution has been found? We currently have the same issue (superset version 4.0.6).

[landryb]

Alternatively, we could change the backend

superset/superset/views/dashboard/views.py

Line 117 in 6575cac

@expose("/new/")

to expose /new instead of /new/ and I think that would work too.

fwiw, it should also be possible to add @expose('/new') next to @expose('/new/'), this way both routes work, that's backwards-compatible, and doesn't need fixing in the frontend. I've tested it locally.

[malcolm061990]

HI @dpgaspar
Can please someone review this PR?