Fabric Spark - EH Connector #51211
Open
Fabric Spark - EH Connector #51211
+46
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vikram-Atreya3
commented
Jun 18, 2025
| @@ -58,7 +58,7 @@ private[kafka010] class KafkaSourceProvider extends DataSourceRegister | |||
| with Logging { | |||
| import KafkaSourceProvider._ | |||
|
|
|||
| override def shortName(): String = "kafka" | |||
| override def shortName(): String = "eventstreams" | |||
Vikram-Atreya3
commented
Jun 18, 2025
| @@ -357,6 +358,29 @@ private[kafka010] class KafkaSourceProvider extends DataSourceRegister | |||
| validateGeneralOptions(params) | |||
| } | |||
|
|
|||
| private def translateEventStreamProperties(params: CaseInsensitiveMap[String]) | |||
| : CaseInsensitiveMap[String] = { | |||
There was a problem hiding this comment.
Use reflection instead of import
| @@ -357,6 +358,29 @@ private[kafka010] class KafkaSourceProvider extends DataSourceRegister | |||
| validateGeneralOptions(params) | |||
| } | |||
|
|
|||
| private def translateEventStreamProperties(params: CaseInsensitiveMap[String]) | |||
There was a problem hiding this comment.
Method name should be translateEventStreamPropertiesToKafkaProperties
| if (params.contains(EVENTSTREAM_NAME_OPTION_KEY) || | ||
| params.contains(EVENTSTREAM_ARTIFACT_ID_OPTION_KEY) || | ||
| params.contains(EVENTSTREAM_CONSUMER_GROUP_OPTION_KEY)) { | ||
| validateEventStreamOptions(params) |
There was a problem hiding this comment.
We should perform validation in eventstream jar, we should make minimal changes in spark code base
There was a problem hiding this comment.
In short, my suggestion is to remove this validation method from here
| params.contains(EVENTSTREAM_ARTIFACT_ID_OPTION_KEY) || | ||
| params.contains(EVENTSTREAM_CONSUMER_GROUP_OPTION_KEY)) { | ||
| validateEventStreamOptions(params) | ||
| return CaseInsensitiveMap(KafkaOptionsUtils.buildKafkaOptionsFromSparkConfig(params)); |
There was a problem hiding this comment.
Method name should be "EventStreamUtils", KafkaOptionsUtils is a generic name which is more suitable for open source kafka connector utils
| @@ -454,6 +478,7 @@ private[kafka010] class KafkaSourceProvider extends DataSourceRegister | |||
| override def toBatch(): Batch = { | |||
| val caseInsensitiveOptions = CaseInsensitiveMap(options.asScala.toMap) | |||
| validateBatchOptions(caseInsensitiveOptions) | |||
|
|
|||
There was a problem hiding this comment.
These new line changes should be removed
| @@ -613,60 +639,6 @@ private[kafka010] object KafkaSourceProvider extends Logging { | |||
| private val serClassName = classOf[ByteArraySerializer].getName | |||
| private val deserClassName = classOf[ByteArrayDeserializer].getName | |||
|
|
|||
| def checkStartOffsetNotGreaterThanEndOffset( | |||
There was a problem hiding this comment.
May be I am missing something, but why are these methods removed ?
| import org.apache.kafka.clients.consumer.ConsumerConfig | ||
| import org.apache.kafka.clients.producer.ProducerConfig | ||
| import org.apache.kafka.common.TopicPartition |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add translate function for eventstream properties to kafka properties
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?