[SPARK-52492][SQL] Make InMemoryRelation.convertToColumnarIfPossible customizable #51189
+100
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
requested changes
Jun 16, 2025
| * @return The output plan. Could either be a columnar plan if the input plan is convertible, or | ||
| * the input plan unchanged if no viable conversion can be done. | ||
| */ | ||
| @Since("4.0.1") |
There was a problem hiding this comment.
According to the Apache Spark backporting policy, this should be 4.1.0 because only bug-fixes are allowed for branch-4.0.
There was a problem hiding this comment.
Thanks. Addressed and also updated Target Version/s field in the JIRA ticket.
zhztheplayer
force-pushed
the
wip-cache-customize-unwrap
branch
from
32a0fc7 to
63971eb
Compare
zhztheplayer
force-pushed
the
wip-cache-customize-unwrap
branch
from
63971eb to
a353773
Compare
yaooqinn
approved these changes
Jun 18, 2025
sql/core/src/main/scala/org/apache/spark/sql/columnar/CachedBatchSerializer.scala
Show resolved
Hide resolved
…tchSerializer.scala
|
@yaooqinn Thanks for amending the annotation! |
|
Merged to master, thank you @zhztheplayer @dongjoon-hyun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SPARK-52492
What changes were proposed in this pull request?
This PR moves
InMemoryRelation.convertToColumnarIfPossibleto as a public API ofCachedBatchSerializer.Why are the changes needed?
TL;DR: So that plugins like Gluten could have the relevant logic customized for their own catch serializers.
Currently, InMemoryRelation.convertToColumnarIfPossible is highly coupled with vanilla Spark's columnar processing logic. It unwraps the input columnar plan by removing the topmost ColumnarToRowExec, the assumes that the outcome RDD after this process can be recognized by the user-customized cache serializer.
But sometimes this assertion is invalid. As in the Apache Gluten project, we may continue distiguishing plans that are all have
supportsColumnar=truewith different columnar batch types. So even the topmostColumnarToRowExecis removed, we still don't know whether the columnar RDD unwrapped can be accepted by Gluten's cache serializer (assuming it only handles one certain type of columnar batch or something).So in Gluten we had a rule to workaround the logic in InMemoryRelation.convertToColumnarIfPossible: https://github.com/apache/incubator-gluten/blob/c6461b4e0c7d3022a31fa832aeab588b1a3200e6/gluten-substrait/src/main/scala/org/apache/gluten/extension/columnar/MiscColumnarRules.scala#L192-L217. This is the best way we had thought about to get through the issue but it's still not elegant, especially the rule is even caller-sensitive as it needs to determine whether it's called in the caching planning process or not.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
With the added UTs.