[SPARK-52439][SQL] Support creating check constraint with NULL #51146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @aokolnychyi as well |
gengliangwang
changed the title
cloud-fan
reviewed
Jun 12, 2025
| @@ -78,6 +78,7 @@ class V2ExpressionBuilder(e: Expression, isPredicate: Boolean = false) extends L | |||
| expr: Expression, isPredicate: Boolean = false): Option[V2Expression] = expr match { | |||
| case Literal(true, BooleanType) => Some(new AlwaysTrue()) | |||
| case Literal(false, BooleanType) => Some(new AlwaysFalse()) | |||
| case Cast(Literal(null, NullType), BooleanType, _, _) if isPredicate => Some(new AlwaysNull()) | |||
There was a problem hiding this comment.
why is it not constant folded to Literal(null, BooleanType)?
There was a problem hiding this comment.
This happens in analyzer rule ResolveTableSpec.
If we proactively constant folding it, the current-like expressions won't be resolved
cloud-fan
reviewed
Jun 12, 2025
| * @since 4.1.0 | ||
| */ | ||
| @Evolving | ||
| public final class AlwaysNull extends Predicate implements Literal<Boolean> { |
There was a problem hiding this comment.
do we have to add it? can v2 Literal do the work?
There was a problem hiding this comment.
It has to be a V2 Predicate:
https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala#L58
Also, having AlwaysNull besides AlwaysTrue and AlwaysFalse is reasonable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Before the changes, there will be complation error if creating a check constraint with null
check(null). This PR fixes the issue.Does this PR introduce any user-facing change?
No
How was this patch tested?
New UT
Was this patch authored or co-authored using generative AI tooling?
No