[WIP][PS] Enable divide-by-zero for boolean floordiv with ANSI enabled #51079
+14
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failed test is irrelevant: |
HyukjinKwon
reviewed
Jun 4, 2025
xinrong-meng
commented
Jun 13, 2025
| @@ -132,7 +128,7 @@ def test_floordiv(self): | |||
| self.assertRaises(TypeError, lambda: b_psser // b_psser) | |||
| self.assertRaises(TypeError, lambda: b_psser // True) | |||
|
|
|||
| self.assert_eq(b_pser // pdf["float"], b_psser // psdf["float"]) | |||
| self.assert_eq((b_pser // pdf["float"]).astype("int"), b_psser // psdf["float"]) | |||
There was a problem hiding this comment.
According to https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.floordiv.html, as well as, integers should always be returned.
|
@ueshin would you please review? |
ueshin
reviewed
Jun 16, 2025
| if isinstance(right, numbers.Number): | ||
| left = transform_boolean_operand_to_numeric(left, spark_type=as_spark_type(type(right))) | ||
| return left // right |
There was a problem hiding this comment.
This will be a numeric floor. I'm wondering if the numeric devision is ok or not.
I guess we should visit it first?
There was a problem hiding this comment.
>>> ps.Series([0,1,2]) // 0
...
pyspark.errors.exceptions.captured.ArithmeticException: [DIVIDE_BY_ZERO] Division by zero. Use `try_divide` to tolerate divisor being 0 and return NULL instead. If necessary set "spark.sql.ansi.enabled" to "false" to bypass this error. SQLSTATE: 22012
== DataFrame ==
"__div__" was called from
<stdin>:1I guess fixing this will fix the boolean case as well.
There was a problem hiding this comment.
Good catch! Filed #51209
xinrong-meng
changed the title
xinrong-meng
changed the title
xinrong-meng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Enable divide-by-zero for boolean floordiv with ANSI enabled
Why are the changes needed?
Ensure pandas on Spark works well with ANSI mode on.
Part of https://issues.apache.org/jira/browse/SPARK-52169.
Does this PR introduce any user-facing change?
Yes
FROM
TO
How was this patch tested?
Unit tests.
Was this patch authored or co-authored using generative AI tooling?
No