Skip to content

[Feature][Zeta] Support view master/worker node log files #9265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Tangruilin
Copy link

feat #9050

Purpose of this pull request

Support view master/worker node log files in ui

Does this PR introduce any user-facing change?

ui in master and worker is changed

How was this patch tested?

do not need test code

Check list

@github-actions github-actions bot added the Zeta label May 4, 2025
@Tangruilin Tangruilin marked this pull request as draft May 4, 2025 15:39
@nielifeng nielifeng requested a review from Copilot May 6, 2025 06:29
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds UI support for viewing log files from master and worker nodes.

  • Introduces a new log viewer page component (logs.tsx) that utilizes the NodeLog component.
  • Updates the managers view and router to include links/routes for accessing log files.
  • Adds supporting service and types for fetching node log data.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
seatunnel-engine/seatunnel-engine-ui/src/views/managers/logs.tsx New log viewer page utilizing NodeLog component
seatunnel-engine/seatunnel-engine-ui/src/views/managers/index.tsx Adds a new "Action" column with a log view button and the corresponding navigation logic
seatunnel-engine/seatunnel-engine-ui/src/service/node-log/types.ts Defines the NodeLog interface for log data
seatunnel-engine/seatunnel-engine-ui/src/service/node-log/index.ts Implements service functions to retrieve log data
seatunnel-engine/seatunnel-engine-ui/src/router/routes.ts Registers new routes for accessing master and worker logs
seatunnel-engine/seatunnel-engine-ui/src/components/node-log/index.tsx Implements the NodeLog component to display logs in a collapsible layout
Comments suppressed due to low confidence (2)

seatunnel-engine/seatunnel-engine-ui/src/views/managers/index.tsx:42

  • The function 'view' is declared but not used; consider removing it to reduce code clutter.
const view = (row: Monitor) => {}

seatunnel-engine/seatunnel-engine-ui/src/views/managers/index.tsx:92

  • [nitpick] Consider updating the button label from 'ViewLog' to 'View Log' for improved readability.
{ default: () => 'ViewLog' }

@hailin0
Copy link
Member

hailin0 commented May 11, 2025

hi @Tangruilin

cc #9050 (comment)

@Tangruilin
Copy link
Author

hi @Tangruilin

cc #9050 (comment)

I may deal with it these days

@nielifeng
Copy link
Contributor

@Tangruilin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants