-
Notifications
You must be signed in to change notification settings - Fork 2k
[Catalog][DM][Improve] dm catalog and dm auto create table and auto create table add constraintKey #5572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
[Catalog][DM][Improve] dm catalog and dm auto create table and auto create table add constraintKey #5572
Conversation
Shall we add some test case? |
Done add dm autocreate table e2e and is pass |
...c/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/dm/DamengCatalog.java
Show resolved
Hide resolved
import java.util.stream.Collectors; | ||
|
||
// todo Abstract the concatenation common content of jdbc auto-build statements | ||
public abstract class AbstractJdbcCreateTableSqlBuilder { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to raise a pr for modification about AbstractJdbcCreateTableSqlBuilder
and related classes in existing code firstly, and make the improvement on dm catalog in another pr.
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note
.