Skip to content

[Catalog][DM][Improve] dm catalog and dm auto create table and auto create table add constraintKey #5572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 37 commits into
base: dev
Choose a base branch
from

Conversation

XiaoJiang521
Copy link
Contributor

Purpose of this pull request

  1. mysql pg sqlserver oracle and dm auto create table add constraintKey
  2. dm catalog and dm auto create table

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@XiaoJiang521 XiaoJiang521 changed the title Dev dm udpdate gettablename [Catalog][DM][Imporve] dm catalog and dm auto create table and auto create table add constraintKey Sep 27, 2023
@XiaoJiang521 XiaoJiang521 changed the title [Catalog][DM][Imporve] dm catalog and dm auto create table and auto create table add constraintKey [Catalog][DM][Improve] dm catalog and dm auto create table and auto create table add constraintKey Sep 27, 2023
@Hisoka-X
Copy link
Member

Shall we add some test case?

@XiaoJiang521
Copy link
Contributor Author

Shall we add some test case?

Done add dm autocreate table e2e and is pass

import java.util.stream.Collectors;

// todo Abstract the concatenation common content of jdbc auto-build statements
public abstract class AbstractJdbcCreateTableSqlBuilder {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to raise a pr for modification about AbstractJdbcCreateTableSqlBuilder and related classes in existing code firstly, and make the improvement on dm catalog in another pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants