[core] Automatically detect changes to the expiration policy. #5944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhoulii
force-pushed
the
auto-detect-conf
branch
from
ccde03f to
232d135
Compare
JingsongLi
reviewed
Jul 25, 2025
| @@ -79,6 +87,12 @@ public ExpireSnapshots config(ExpireConfig expireConfig) { | |||
|
|
|||
| @Override | |||
| public int expire() { | |||
| TableSchema latestTableSchema = this.schemaManager.latest().get(); | |||
There was a problem hiding this comment.
This will bring additional IO access. Can you introduce a new option to describe whether a refresh is needed?
zhoulii
force-pushed
the
auto-detect-conf
branch
from
232d135 to
a431454
Compare
zhoulii
force-pushed
the
auto-detect-conf
branch
from
a431454 to
9fc3b16
Compare
JingsongLi
reviewed
Jul 28, 2025
| @@ -443,6 +443,12 @@ public InlineElement getDescription() { | |||
| .withDescription( | |||
| "The maximum number of snapshots allowed to expire at a time."); | |||
|
|
|||
| public static final ConfigOption<Boolean> DETECT_EXPIRATION_SETTING_ENABLED = | |||
| key("detect-expiration-setting.enabled") | |||
There was a problem hiding this comment.
snapshot.expire.detect-config.enabled?
|
Thanks for the review @JingsongLi . All comments have been addressed, Please take another look when you have a moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #5943
Tests
API and Format
Documentation