Skip to content

[core] formatTable supports defaultValue #5893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

XiaoHongbo-Hope
Copy link
Contributor

Purpose
formatTable supports defaultValue

Linked issue: close #xxx

Tests

DDLWithHiveCatalogTestBase.test("Paimon DDL with hive catalog: default value")

API and Format

Documentation

@@ -747,11 +747,9 @@ abstract class DDLWithHiveCatalogTestBase extends PaimonHiveTestBase {

// test non paimon table
// todo: support default value for paimon format table
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can delete this line

@@ -1071,6 +1073,13 @@ private Table createHiveFormatTable(
FormatTable.Format provider = FormatTable.parseFormat(coreOptions.formatType());

Map<String, String> tblProperties = new HashMap<>();
tableSchema.fields().stream()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method maybe can be placed in more general place, such as alter table, which may also require this logic

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method maybe can be placed in more general place, such as alter table, which may also require this logic

Currently, formatTable does not support alter table, maybe we can support it in next PR.

@XiaoHongbo-Hope XiaoHongbo-Hope changed the title formatTable supports defaultValue [core] formatTable supports defaultValue Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants