Skip to content

[core] Output the relevant table names in the log to assist in troubleshooting the problem. #5557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

thomasg19930417
Copy link

…ng the problem.

Purpose

Linked issue: close #xxx

Tests

API and Format

Documentation

…ng the problem.
@thomasg19930417 thomasg19930417 changed the title Output the relevant table names in the log to assist in troubleshooting the problem. [core]Output the relevant table names in the log to assist in troubleshooting the problem. Apr 29, 2025
@thomasg19930417 thomasg19930417 changed the title [core]Output the relevant table names in the log to assist in troubleshooting the problem. [core] Output the relevant table names in the log to assist in troubleshooting the problem. Apr 29, 2025
@wwj6591812
Copy link
Contributor

Error: src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java:[1322,53] (whitespace) WhitespaceAround: '+' is not preceded with whitespace.
Error: src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java:[1322,54] (whitespace) WhitespaceAround: '+' is not followed by whitespace.

@thomasg19930417
Copy link
Author

@wwj6591812 The format has been modified.

@JingsongLi JingsongLi requested a review from Copilot May 7, 2025 06:37
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances error logging by appending the affected table name to the error messages, which will assist troubleshooting by providing more context.

  • Updates the error message in PartitionExpireTest to include the table name.
  • Updates the error message in FileStoreCommitImpl to include the table name.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
paimon-core/src/test/java/org/apache/paimon/operation/PartitionExpireTest.java Updated error message string to include table name for better troubleshooting.
paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java Updated error message string to include table name for enhanced logging.
Comments suppressed due to low confidence (2)

paimon-core/src/test/java/org/apache/paimon/operation/PartitionExpireTest.java:341

  • [nitpick] Consider removing the leading space before the comma to maintain a consistent message format (e.g., use ", tableName: " instead of " ,tableName: ").
+                                + " ,tableName: "

paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java:1322

  • [nitpick] Consider removing the leading space before the comma to ensure consistent formatting in the error message (e.g., use ", tableName: " instead of " ,tableName: ").
+                                    + " ,tableName: "

@thomasg19930417 thomasg19930417 marked this pull request as draft May 17, 2025 09:50
@JingsongLi
Copy link
Contributor

Why this PR is draft? Can you continue to work this PR? @thomasg19930417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants