Fixes to address 2K message size limit when using SyslogUDPSource. #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, it occurs to me that I should probably set datagramSize to the min of datagramSize and maxsize. |
|
Can one of the admins verify this patch? |
|
Is this project still alive? |
|
Yes |
waidr
pushed a commit
to waidr/flume
that referenced
this pull request
Jul 24, 2019
fsfetcher: lina auth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see https://issues.apache.org/jira/browse/FLUME-2885. Currently, the SyslogUDPSource truncates messages > 2K. With this fix, the default behavior remains the same (2K is used for the buffer size), but if a user specifies a value for datagramSize in the flume configuration, then that size is used instead. If we want to use AdaptiveReceiveBufferSizePredictor to avoid allocating buffers that are larger than necessary, 'someone' is going to have to develop a more comprehensive fix. This at least allows for udp syslog users with messages larger than 2K to process their messages without truncation.
I have deployed this fix in two environments where syslog messages can be larger than 2K, and it works as expected.