Skip to content

Size based rolling support for file sink #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

praste
Copy link

@praste praste commented Jan 19, 2016

This fixes #FLUME-2856.
Also added support use a fixed naming pattern for files.
Support for allowing to delete old sink files is also added.

Updated documentation for above mentioned changes.

To support maxHistory feature (i.e. to delete older files) I had to be able to predict file names. I introduced new required property for RollingFileSink called fileName. This is the only backwards incompatible change from end users point of view. I have also made a couple of backwards incompatible changes to PathManager class. However PathManager class is not being used by any class other than RollingFileSink class.

I am open to rewrite some of the changes if people think refactoring will cause any issues.

This fixes #FLUME-2856.
Also added support use a fixed naming pattern for files.
Support for allowing to delete old sink files is also added.

Updated documentation for above mentioned changes
@praste
Copy link
Author

praste commented Jan 19, 2016

BTW I don't know if I was supposed to send a pull request of attach patch to the JIRA.
It's been more than a month since I have attached patch to the FLUME-2856. I have also sent a couple of message to flume-dev list and tried sending emails to flume a couple of moderators/contributors email addressed documented on the flume's team page, with no avail.

@praste
Copy link
Author

praste commented Jan 27, 2016

any advise????

@asfgit
Copy link

asfgit commented Aug 17, 2018

Can one of the admins verify this patch?

waidr pushed a commit to waidr/flume that referenced this pull request Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants