Size based rolling support for file sink #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #FLUME-2856.
Also added support use a fixed naming pattern for files.
Support for allowing to delete old sink files is also added.
Updated documentation for above mentioned changes.
To support
maxHistory
feature (i.e. to delete older files) I had to be able to predict file names. I introduced new required property forRollingFileSink
calledfileName
. This is the only backwards incompatible change from end users point of view. I have also made a couple of backwards incompatible changes toPathManager
class. HoweverPathManager
class is not being used by any class other thanRollingFileSink
class.I am open to rewrite some of the changes if people think refactoring will cause any issues.