Extension-friendly HttpSource #18
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows third-party to developers extend HttpSource behavior easily, without having to reimplement the whole thing.
More specifically:
org.mortbay.jetty.servlet.Context
.protected
, to let third party developers extend from it.FlumeHTTPServlet
to customizeHttpServletResponse
before it is flushed.We developed this patch because we had to add a custom servlet filter to the Jetty context.
Having this patch applied, a third-party developer could easily extend HttpSource like this: