FLUME-3023 {variable} substitution doesn't work for property 'fileSuffix' #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bessbd
requested changes
Mar 1, 2017
| String translatedSuffixString = BucketPath.escapeString(SUFFIX, e.getHeaders()); | ||
|
|
||
| BucketWriter bucketWriter = new BucketWriter( | ||
| ROLL_INTERVAL, 0, 0, 0, ctx, "/tmp", "file", "", translatedSuffixString, null, null, |
There was a problem hiding this comment.
Isn't SUFFIX to be supplied here?
There was a problem hiding this comment.
ignore this test I will write a new one ... this seems to be incorrect.
bessbd
requested changes
Mar 15, 2017
|
|
||
| // check that the roll happened correctly for the given data | ||
| Assert.assertTrue("File suffix translation failed: " + fList[0].toUri(), | ||
| fList[0].getName().indexOf(translatedSuffixString) != -1); |
There was a problem hiding this comment.
This could be rewritten as fList[0].getName().contains(translatedSuffixString). Also, I think it should be fList[0].getName().endsWith(translatedSuffixString)
| sink.stop(); | ||
|
|
||
| String translatedSuffixString = | ||
| BucketPath.escapeString(context.getString("hdfs.fileSuffix"), event.getHeaders()); |
There was a problem hiding this comment.
Shouldn't we hard-code the value of translatedSuffixString? (I think it is always "_20170201.avro")
| }; | ||
| Clock prevClock = BucketPath.getClock(); | ||
|
|
||
| BucketPath.setClock(testClock); |
|
Can one of the admins verify this patch? |
waidr
pushed a commit
to waidr/flume
that referenced
this pull request
Jul 24, 2019
rtmp-play log hide node ip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Escaped the suffix before passing it to bucket writer.