FLUME-2984: Fix OOM in thrift source. Make transport buffer configurable. #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonati
reviewed
Jan 2, 2017
There was a problem hiding this comment.
Looks good to me.
Test passes. (mvn test -pl flume-ng-core -Dtest=org.apache.flume.source.TestThriftSource
) Unfortunately the test for the whole module fails for me with - I think irrelevant - missing snappy dependency.
simonati
reviewed
Jan 2, 2017
|
@laxman-ch : thank you for the PR! Is there a way to test this change? (If a unit test is difficult to implement, do you know of any ways to reproduce the issue manually? Ie. "this is the config I use, this is the input that causes OOM".) |
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.