Skip to content

Make Node and ExprTransform affect OpPropFunc arguments #3264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Aklakan
Copy link
Contributor

@Aklakan Aklakan commented Jun 18, 2025

As the title says. (If desired I can create an issue). The issue occurred to me when I was trying to post process variable names in Ops after the optimizer had already run. OpPropFunc arguments were not affected then.
One detail question is whether the NodeTransform should affect the property function URI.
My argument against it are:

  • It's probably desired to prevent a node transform from mapping a property function name to a blank node or literal.
  • Renaming property function names in the BGPs could be done before the optimizer runs.
  • In the work case, it would still possible to subclass TransformCopy just for that case.

  • Tests are included.
  • Commits have been squashed to remove intermediate development commit messages.
  • (Key commit messages start with the issue number (GH-xxxx))

By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.


See the Apache Jena "Contributing" guide.

@Aklakan Aklakan changed the title Make Node and ExprTransform affect arguments of OpPropFunc. Make Node and ExprTransform affect OpPropFunc arguments Jun 18, 2025
@Aklakan Aklakan force-pushed the 2025-06-18_propfunc_fix branch from 00e43b9 to e9af72e Compare June 18, 2025 14:59
@Aklakan Aklakan force-pushed the 2025-06-18_propfunc_fix branch from e9af72e to 329a6c4 Compare June 18, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant