GH-3253: Apply transforms to present Elements of ExprFunctionOp instances. #3254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aklakan
commented
Jun 15, 2025
|
|
||
| @Override | ||
| public int numArgs() { return 0; } | ||
|
|
||
| @Override | ||
| public Expr copySubstitute(Binding binding) { | ||
| Op op2 = Substitute.substitute(getGraphPattern(), binding) ; |
There was a problem hiding this comment.
Could copySubstitute in principle delegate to applyNodeTransform with a NodeTransform based on the binding? Or are there subtle semantic difference?
Aklakan
commented
Jun 15, 2025
Comment on lines
+150
to
+153
| boolean workToDo = vars.stream().anyMatch(v-> { | ||
| Node n = nodeTransform.apply(v); | ||
| return n != null && !v.equals(n); | ||
| }); |
There was a problem hiding this comment.
This intent of this change is to remove the need for the explicit Map next to the NodeTransform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved #3253.
Pull request Description: Transforms now also affect Elements of ExprFunctionOp instances.
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.
See the Apache Jena "Contributing" guide.