AWS: Support metrics tracking when using Analytics Accelerator stream #13348
+366
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stubz151
reviewed
Jun 19, 2025
aws/src/integration/java/org/apache/iceberg/aws/s3/S3TestUtil.java
Outdated
Show resolved
Hide resolved
fuatbasik
reviewed
Jun 19, 2025
There was a problem hiding this comment.
thanks a lot @SanjayMarreddi . I put some comments, mostly nitpicks.
aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3MultipartUpload.java
Outdated
Show resolved
Hide resolved
aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java
Show resolved
Hide resolved
aws/src/integration/java/org/apache/iceberg/aws/s3/TestFlakyS3InputStream.java
Outdated
Show resolved
Hide resolved
rajdchak
reviewed
Jun 19, 2025
aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java
Show resolved
Hide resolved
…erator is enabled
SanjayMarreddi
force-pushed
the
add_metrics_in_analytics_accelerator_stream
branch
from
b3cfc37 to
cb0c707
Compare
SanjayMarreddi
force-pushed
the
add_metrics_in_analytics_accelerator_stream
branch
from
cb0c707 to
383b38b
Compare
SanjayMarreddi
force-pushed
the
add_metrics_in_analytics_accelerator_stream
branch
from
383b38b to
4195290
Compare
SanjayMarreddi
force-pushed
the
add_metrics_in_analytics_accelerator_stream
branch
from
4195290 to
af434f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #13295. It addresses the feature gap in AAL stream of not tracking read metrics (
readBytes,readOperations). Please note that this PR also depends on #13347 to be able to test this feature properly with an integration test.Testing
Added a new integration test
testMetricsthat works for both existingS3InputStreamand also the Analytics Accelerator Stream.