Skip to content

[#13239]Remove extra \ in Kafka Connect Configuration docs #13240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

raveendra11
Copy link
Contributor

Title : [#13239] : Remove extra \ in Kafka Connect Configuration docs

@github-actions github-actions bot added the docs label Jun 4, 2025
@bryanck
Copy link
Contributor

bryanck commented Jun 4, 2025

Thanks for the PR @raveendra11 . I'm not in favor of this change as it causes issues rendering the markdown in vim and other editors.

@raveendra11
Copy link
Contributor Author

Thanks for the PR @raveendra11 . I'm not in favor of this change as it causes issues rendering the markdown in vim and other editors.

Oh Okay! Are we closing this issue?

@manuzhang
Copy link
Collaborator

@bryanck what's the issue in vim and other editors? Do you have a solution in mind that works for all?

@ebyhr
Copy link
Contributor

ebyhr commented Jun 5, 2025

We could change to _table-name_ instead, like Spark page. JDBC, AWS and Hive still use \> pattern, though.

raveendra11 and others added 2 commits June 5, 2025 13:32

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@raveendra11
Copy link
Contributor Author

We could change to _table-name_ instead, like Spark page. JDBC, AWS and Hive still use \> pattern, though.

@manuzhang changed as per @ebyhr suggestion, @bryanck are we good with this?

raveendra11 and others added 2 commits June 8, 2025 22:29

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@manuzhang
Copy link
Collaborator

@raveendra11 It looks you are adding unrelated commits to this PR.

This reverts commit 93db051.

reverting the commit as it is making changes to previous pull request.# Please enter the commit message for your changes. Lines starting
@raveendra11
Copy link
Contributor Author

raveendra11 commented Jun 9, 2025

@raveendra11 It looks you are adding unrelated commits to this PR.
@manuzhang Yeah, I have reverted to those commits.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants