Build: Fix errorprone warnings #13217
Open
+92
−140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CuteChuanChuan
force-pushed
the
raymond/fix-errorprone-warnings-in-building
branch
2 times, most recently
from
d89e764 to
124e055
Compare
CuteChuanChuan
force-pushed
the
raymond/fix-errorprone-warnings-in-building
branch
from
124e055 to
36f869f
Compare
3 tasks
- UnnecessaryParentheses at ADLSFileIO#136: remove unnecessary parentheses - ObjectsHashCodePrimitive at DynamicRecordInternalSerializer#234: use Boolean.hashCode instead of Objects.hashCode - MixedMutabilityReturnType at DynamicWriter#202: use ImmutableList for consistent immutable collection returns - ImmutableEnumChecker at Timestamps#47: Replace SerializableFunction with @immutable Apply class for enum immutability - DangerousParallelStreamUsage at BigQueryMetastoreClientImpl#491: Replace parallel stream with Tasks.foreach() for consistent error handling pattern
CuteChuanChuan
force-pushed
the
raymond/fix-errorprone-warnings-in-building
branch
from
36f869f to
ae6f240
Compare
|
Hi @ajantha-bhat, |
ajantha-bhat
approved these changes
Jun 16, 2025
| NANOS_TO_HOUR(ChronoUnit.HOURS, "hour", TimestampUnit.NANOS); | ||
|
|
||
| @Immutable | ||
| static class Apply implements SerializableFunction<Long, Integer> { |
There was a problem hiding this comment.
comment for other reviewers:
To fix errorprone warning, followed the Dates enum style.
|
Hi @ajantha-bhat , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Details:
Verification:
./gradlew clean build -x test -x integrationTest --no-build-cacheto ensure no ErrorProne warnings./gradlew :iceberg-bigquery:testto verify BigQueryMetastoreClientImpl modifications pass tests./gradlew :iceberg-api:testto verify Timestamps modifications don't break existing functionality