Fix(catalog): Only remove metadata files if TableOp created a new one #13169
+58
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In multiple Table ops (Glue, Dynamo, BigQuery and Nessie) a failing operation will clean up the metadata file. However it should only do so if it was the one to create the metadata file in the first place. Otherwise, an operation like `registerTable` could corrupt other catalog that rely on the existence of the metadata file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13014
In multiple Table ops (Glue, Dynamo, BigQuery and Nessie) a failing operation will clean up the metadata file.
However it should only do so if it was the one to create the metadata file in the first place.
Otherwise, an operation like
registerTablecould corrupt other catalog that rely on the existence of the metadata file