Skip to content

Website: Add PyIceberg, IcebergRust, and IcebergGo to top nav bar #12950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

petern48
Copy link

@petern48 petern48 commented May 2, 2025

Closes #12910

@github-actions github-actions bot added the docs label May 2, 2025
Copy link
Collaborator

@manuzhang manuzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. We also need to remove their links from java docs
  2. We'd better have some form of pull-down list of websites. Otherwise, the nav bar will be too long.

@petern48
Copy link
Author

I experimented with trying to achieve what the Spark docs do (as you requested here) by nesting the docs inside a new nav bar field using the below change, and it does NOT create a dropdown. Instead, it just sends you directly to the PyIceberg website (the first entry), making the rest of the links inaccessible. I did some research, and it seems not all mkdoc themes support dropdowns, unfortunately.

nav:
  ...
  - Other:
    - PyIceberg: https://py.iceberg.apache.org/
    - IcebergRust: https://rust.iceberg.apache.org/
    - IcebergGo: https://pkg.go.dev/github.com/apache/iceberg-go/

Instead, I propose that we instead nest them under the existing Docs nav bar entry in the following way. Here's what the new code changes looks like.

image

Expanding the "Iceberg" section, we can then see what was previously in the Docs nav bar item.
image

When you originally click on Docs at the top, it defaults to the first page entry (Iceberg -> nightly -> Introduction) as before. What do you think @manuzhang?

@petern48 petern48 requested a review from manuzhang May 11, 2025 15:21
@manuzhang
Copy link
Collaborator

@petern48 Thanks, I've opened a discussion on the dev list for a more comprehensive restructure of the side navigation. Let's see what others think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Website: add links to PyIceberg / IcebergRust / IcebergGo / IcebergCpp
2 participants