Skip to content

GROOVY-11601: remove support for expression list in for-each statement #2174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eric-milles
Copy link
Member

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.4704%. Comparing base (876fbed) to head (6237562).
Report is 173 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##               master      #2174        +/-   ##
==================================================
+ Coverage     68.8710%   71.4704%   +2.5994%     
- Complexity      29570      35204      +5634     
==================================================
  Files            1421       1423         +2     
  Lines          113714     129434     +15720     
  Branches        19715      25501      +5786     
==================================================
+ Hits            78316      92507     +14191     
- Misses          28787      30202      +1415     
- Partials         6611       6725       +114     
Files with missing lines Coverage Δ
...va/org/apache/groovy/parser/antlr4/AstBuilder.java 89.4434% <100.0000%> (+3.1201%) ⬆️

... and 75 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@daniellansun
Copy link
Contributor

It's better not to break existing users' code unless we have to do.

@eric-milles
Copy link
Member Author

Do you have an example of something that requires this? It is quite costly to support arbitrary expression list in for loop.

@paulk-asert
Copy link
Contributor

I added some example to the Jira and asked Jochen (via slack) if he had other examples (but he hasn't responded yet).

@eric-milles eric-milles closed this May 8, 2025
@eric-milles eric-milles deleted the GROOVY-11601 branch May 8, 2025 14:53
@eric-milles eric-milles restored the GROOVY-11601 branch May 8, 2025 14:53
@eric-milles eric-milles reopened this May 8, 2025
@eric-milles eric-milles deleted the GROOVY-11601 branch June 10, 2025 16:06
@eric-milles eric-milles restored the GROOVY-11601 branch June 10, 2025 16:06
@eric-milles eric-milles reopened this Jun 10, 2025
@eric-milles
Copy link
Member Author

sorry, I keep misinterpreting the icon in the branches list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants