[postgres] fix when backfill will scan all table schame which match config #3985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joyCurry30 i add new pr from #3979 |
| StreamSplit streamSplit = (StreamSplit) sourceSplitBase; | ||
| // when backfilled, will send specified table schema. | ||
| return !StreamSplit.STREAM_SPLIT_ID.equalsIgnoreCase(streamSplit.splitId()) | ||
| && streamSplit.getTableSchemas() != null |
There was a problem hiding this comment.
is streamSplit.getTableSchemas() != null && streamSplit.getTableSchemas().size() == 1; needed? Whether !StreamSplit.STREAM_SPLIT_ID.equalsIgnoreCase(streamSplit.splitId()) is enough?
There was a problem hiding this comment.
it can be simple, done.
@loserwang1024
There was a problem hiding this comment.
@loserwang1024 please review again.
…onfig ------ remove condition
…onfig ------ remove condition
joyCurry30
approved these changes
Apr 18, 2025
loserwang1024
approved these changes
Apr 18, 2025
|
@leonardBang how to fix the CI test, the code which have problem is not changed by me |
you can try to rebase to latest master to fix the failed ci tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copy pr #3979