Skip to content

[docs][minor] Correct Typos in Documentation/Code #3451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Karl-WangSK
Copy link

This change ensures that the log message is clear and free of typographical errors.

@Karl-WangSK
Copy link
Author

@yuxiqian PTAL

@yuxiqian
Copy link
Member

yuxiqian commented Jul 4, 2024

Thanks for @Karl-WangSK's contribution! It reminds me that JetBrains IDE always complains about typos in code comments. Would you like to fix them together if possible?

@yuxiqian
Copy link
Member

yuxiqian commented Jul 4, 2024

Looks good! Since some changes affected test cases, could @ruanhang1993 please trigger the CI?

@Karl-WangSK Karl-WangSK changed the title [docs][minor] Fix typo in log message: "oder" to "order" [docs][minor] Correct Typos in Documentation/Code Jul 7, 2024
@Karl-WangSK
Copy link
Author

Karl-WangSK commented Jul 8, 2024

hello , pls can trigger the CI e2e check? this cancelled not related to this pr. @ruanhang1993 @leonardBang

@yuxiqian
Copy link
Member

yuxiqian commented Jul 9, 2024

Seems OracleE2eITCase.testOracleCDC missed a change inside:

arrays first differed at element [7];
expected:<...,jacket,water resist[a]nt black wind breake...>
 but was:<...,jacket,water resist[e]nt black wind breake...>

@Karl-WangSK
Copy link
Author

ready to merge @leonardBang

@yuxiqian
Copy link
Member

yuxiqian commented Sep 5, 2024

Hi @Karl-WangSK, any updates on this PR?

@Karl-WangSK Karl-WangSK reopened this Sep 5, 2024
@Karl-WangSK
Copy link
Author

Hi @Karl-WangSK, any updates on this PR?

sry for late, revised

@Karl-WangSK Karl-WangSK requested a review from yuxiqian September 5, 2024 15:10
Copy link

github-actions bot commented Nov 5, 2024

This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Nov 5, 2024
@leonardBang
Copy link
Contributor

@Karl-WangSK Would you like to rebase this PR? and then we can review this PR again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants