Skip to content

fix(marker): fix bug of #20166 #21042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025
Merged

fix(marker): fix bug of #20166 #21042

merged 1 commit into from
Jun 19, 2025

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Jun 18, 2025

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

#20166 breaks the case of marker-case.html, where marker is used in pie series and has no coordinate.

Fix the order of importing files in test/dataZoom-action.html, which is not related to this issue but fixed together for convenience. It seems lib/config.js should be imported before lib/simpleRequire.js, otherwise, the local echarts file cannot be found:

image

Fixed issues

Details

Before: What was the problem?

image

After: How does it behave after the fixing?

No error message and chart is rendered as expected.

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Jun 18, 2025

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

Copy link
Contributor

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-21042@3aac20d

@Ovilia Ovilia merged commit 0b863d1 into v6 Jun 19, 2025
2 checks passed
@Ovilia Ovilia deleted the fix-relativeTo branch June 19, 2025 02:03
Copy link

echarts-bot bot commented Jun 19, 2025

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia added this to the 6.0.0 milestone Jun 19, 2025
@Ovilia Ovilia added the PR: supplementary Fix bugs or enhance a feature introduced in this version, which should ignore in the release note. label Jun 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: author is committer PR: doc unchanged PR: supplementary Fix bugs or enhance a feature introduced in this version, which should ignore in the release note. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants