Support negative values for log Scale. #20872
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Antti-Palola
force-pushed
the
fix-logarithmic-scale-negative-below-one
branch
2 times, most recently
from
c67121f to
17b68f2
Compare
|
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20872@17b68f2 |
Support implemented by inverting the extents at input and handling the input as absolute value and finally mapping everything back to negative axes in inverted order. Added test cases for passing through 0 power and new a new file ogScale-negative.html.
Properly inherit IntervalScale and inline the only thing that really was required from Scale base class `unionExtent`.
Add limit to major tick generation to stop at base extents. If log base 10 range is from 4 to 200, previously ticks overflowed from top and bottom to 1-1000. Create minor ticks within decade linearly spaced as before but if the extent is not within even log steps, stop generating at extent end. When major ticks are more than one decade apart, generate a minor tick for each decade up to the split number times.
Antti-Palola
force-pushed
the
fix-logarithmic-scale-negative-below-one
branch
from
85787f2 to
b6aeb01
Compare
|
@Ovilia Hey, could you take a look at this: an improved shot at fixing log scaled line plots. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support implemented by inverting the extents at input and handling the input as absolute value and finally mapping everything back to negative axes in inverted order.
Added test cases for passing through 0 power and new a new file logScale-negative.html.
Brief Information
This pull request is in the type of:
What does this PR do?
Add support for plotting negative values on Log scales.
Fixed issues
Fix a previous PR #16547 more generically and correctly.
Details
Before: What was the problem?
Negative values could not be plotted with log scaling.
After: How does it behave after the fixing?
Log scale can now be used
Before: nothing is drawn
After
Document Info
One of the following should be checked.
There is no mention of negative values having problems in docs.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information