Skip to content

fix(bar): fix background animation when real time sort #18965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

linghaoSu
Copy link
Member

@linghaoSu linghaoSu commented Aug 6, 2023

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

  1. the background color is not clipped after the column is clipped by the rendering range, resulting in overflow
  2. the speed of the background color does not match the speed of the columns

Fixed issues

Details

  1. hide background element when bar element cliped
  2. using realtimeconfig's axis model for background updateProps to achieve consistent speed
Before After
image image
image image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Aug 6, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-18965@2591d3a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 开启动态排序后背景色与柱子分离
2 participants