Skip to content

feat(legend): use series/data name in legend according to series.colorBy #15747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: next
Choose a base branch
from

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Sep 17, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

colorBy was supported in #13788 , enabling using color palettes for each series/data. This PR enhances the legend component so that names of series/data are used in legend items according to colorBy.

Fixed issues

Details

Before: What was the problem?

For bar series colored by data, only the series name is shown in the legend and the color is not representing the data.

After: How is it fixed in this PR?

By default, if the bar series is colored by data, multiple legend items are in the legend component with the name of the data.

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Sep 17, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@Ovilia Ovilia added this to the 5.3 milestone Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant