Fix#12164 Erroneous Behavior when displaying a line chart with multiple data pushes before updating chart data while zoomed in #12266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update 4.7.0
pissang
requested changes
Mar 11, 2020
src/chart/line/lineAnimationDiff.js
Outdated
| @@ -166,6 +166,7 @@ export default function ( | |||
|
|
|||
| // Diff result may be crossed if all items are changed | |||
| // Sort by data index | |||
| rawIndices = Array.from(new Set(rawIndices)); | |||
There was a problem hiding this comment.
Please don't use Array.from and Set because it's not supported in IE. See https://www.echartsjs.com/zh/coding-standard.html
pissang
requested changes
Mar 14, 2020
| rawIndices.splice(i, 1); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
O(n2) algorithm may have performance issue on large data.
Also splice is usually not a performant method and can easily get logic messed up(because the array length is changed after splice). Create a new array(when necessary) is much simpler and has better performance. Check https://jsperf.com/splice-vs-filter
Since there rawIndices has been sorted in the following code. We can loop sortedIndices, and only compare two neighbor rawIndex to see if they are the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fixed issues
Details
Before: What was the problem?
After: How is it fixed in this PR?
Usage
Are there any API changes?
Related test cases or examples to use the new APIs
NA.
Others
Merging options
Other information
https://github.com/apache/incubator-echarts/issues/12164