AIP-81 : Abstracting Operation Calls Using a Generic Method #53323
Conversation
| return DAGResponse.model_validate_json(self.response.content) | ||
| except ServerResponseError as e: | ||
| raise e | ||
| return super().execute_operation(method="get", url="dags/{dag_id}", data_model=DAGResponse) |
There was a problem hiding this comment.
you forgot to make it into an f-string here :)
| **kwargs, | ||
| ): | ||
| try: | ||
| print("try") |
There was a problem hiding this comment.
| print("try") |
|
Additionally, these pieces will be auto generated in the future so let's not make too much effort for now to just unify them |
Oh, do I need to remove it from all methods except list, and do it after release? |
O Nice!!Just like commands ? |
I think you can even include this in your other PR but this change would be more safe after merging other one where we listing all entities so that you don't need to do it again in one of them |
|
Something like in list methods we will call from super and that's it :) |
|
@bugraoz93 Thanks!! If any issues related to |
Many thanks @Prab-27 ! You are one of the sole contributors to airflowctl, I will ping you. After rc release, we would most probably need to work a bit on a couple of parts while testing more. Let's close this for now as even without release I cannot see the value it is bringing. Sorry if I misguided you which cost additional effort! |
|
@bugraoz93 Thanks a lot |
Related discussion: here
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.