Skip to content

CI fix: Bump uv to 0.7.20 #53207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2025
Merged

Conversation

gopidesupavan
Copy link
Member

https://github.com/apache/airflow/actions/runs/16228209328/job/45825176831


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:dev-tools area:production-image Production image improvements and fixes backport-to-v3-0-test Mark PR with this label to backport to v3-0-test branch labels Jul 11, 2025
Copy link
Contributor

@bugraoz93 bugraoz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, Pavan! We may need to add the full test label to run the failed task in the CI. Upgrade Check skipped in the CI

@amoghrajesh amoghrajesh merged commit 13c28dc into apache:main Jul 12, 2025
102 checks passed
Copy link

Backport failed to create: v3-0-test. View the failure log Run details

Status Branch Result
v3-0-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 13c28dc v3-0-test

This should apply the commit to the v3-0-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

@potiuk
Copy link
Member

potiuk commented Jul 12, 2025

Thanks for the fix, Pavan! We may need to add the full test label to run the failed task in the CI. Upgrade Check skipped in the CI

Upgrade check only runs in "canary" by design.

However there is something wrong because we should only "fail" upgrade check when Python, PIP, pre-commit, or Node changes - we should not fail when UV and GOLANG changes. So something is wrong in the upgrade script:

      # For UV we are not failing the upgrade installers check if it is updated because
      # it is upgraded very frequently, so we want to manually upgrade it rather than
      # get notified about it - until it stabilizes in 1.* version
      - name: "Run automated upgrade for uv (not failing - just informational)"
        run: >
          pre-commit run
          --all-files --show-diff-on-failure --color always --verbose
          --hook-stage manual update-installers-and-pre-commit || true
        if: always()
        env:
          UPGRADE_UV: "true"
          UPGRADE_PYTHON: "false"
          UPGRADE_GOLANG: "true"
          UPGRADE_PIP: "false"
          UPGRADE_PRE_COMMIT: "false"
          UPGRADE_NODE_LTS: "false"
      - name: "Run automated upgrade for pip, pre-commit and node (failing if needed)"
        run: >
          pre-commit run
          --all-files --show-diff-on-failure --color always --verbose
          --hook-stage manual update-installers-and-pre-commit
        if: always()
        env:
          UPGRADE_UV: "false"
          UPGRADE_PYTHON: "true"
          UPGRADE_GOLANG: "false"
          UPGRADE_PIP: "true"
          UPGRADE_PRE_COMMIT: "true"
          UPGRADE_NODE_LTS: "true"

The approach we have that we do not want to fail canary build with upgrade check too often - an only when important things change - so we have two upgrade checks running - one will not fail (see || true at the end) - it will just print what needs to be upgraded) when uv, golang need upgrade, the other will fail when Python or PIP changes.

Then when we run update-installers-and-pre-commit - by default it will upgrade everything anyway - so result is that we anyhow upgrade everything when either Python or PIP changes or when we manually run the script when we want to speed up the upgrades of uv for example.

So ... for some reason it failed not as intended as only UV and GOLANG changed.

@potiuk
Copy link
Member

potiuk commented Jul 12, 2025

Ha.... That was the problem:

Traceback (most recent call last):
  File "/home/runner/work/airflow/airflow/./scripts/ci/pre_commit/update_installers_and_pre_commit.py", line 276, in <module>
    latest_python_version = get_latest_python_version(python_version, GITHUB_TOKEN)
  File "/home/runner/work/airflow/airflow/./scripts/ci/pre_commit/update_installers_and_pre_commit.py", line 81, in get_latest_python_version
    response.raise_for_status()  # Ensure we got a successful response
  File "/home/runner/.cache/pre-commit/repotfdo3447/py_env-python3/lib/python3.10/site-packages/requests/models.py", line 1026, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 403 Client Error: rate limit exceeded for url: https://api.github.com/repos/python/cpython/tags?per_page=100&page=1

@potiuk
Copy link
Member

potiuk commented Jul 12, 2025

#53219

potiuk pushed a commit to potiuk/airflow that referenced this pull request Jul 12, 2025
(cherry picked from commit 13c28dc)

Co-authored-by: GPK <[email protected]>
potiuk added a commit that referenced this pull request Jul 12, 2025
(cherry picked from commit 13c28dc)

Co-authored-by: GPK <[email protected]>
@bugraoz93
Copy link
Contributor

Upgrade check only runs in "canary" by design.

Yes, I know that's why I mentioned maybe good to test in the PR CI to be fully sure, but changes are obvious and from pre-commit, so it is not a blocker to see it green :)

@gopidesupavan gopidesupavan deleted the bump-uv-0.7.20 branch July 12, 2025 20:22
stephen-bracken pushed a commit to stephen-bracken/airflow that referenced this pull request Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools area:production-image Production image improvements and fixes backport-to-v3-0-test Mark PR with this label to backport to v3-0-test branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants