Skip to content

Bump mypy to 1.16.1 for airflow-core and fix airflow-core mypy errors #53004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 10, 2025

Conversation

gopidesupavan
Copy link
Member


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - with one nit that mypy dependency is not needed/useful

Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, rest looks good

@gopidesupavan
Copy link
Member Author

BTW i have not updated mypy version to 1.16.1 in devel-common on this PR, my plan is it update once all the fixes completed. that i am iterating with the #52997 will bump mypy version.

Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking better, one comment @gopidesupavan

@potiuk potiuk merged commit bd38225 into apache:main Jul 10, 2025
102 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 10, 2025
… mypy errors (#53004)

* Bump mypy to 1.16.1 and fix airflow-core mypy errors

* Bump mypy to 1.16.1 and fix airflow-core mypy errors

* remove mypy dep from additional_dependencies

* resolve comments
(cherry picked from commit bd38225)

Co-authored-by: GPK <[email protected]>
Copy link

Backport successfully created: v3-0-test

Status Branch Result
v3-0-test PR Link

github-actions bot pushed a commit to astronomer/airflow that referenced this pull request Jul 10, 2025
… mypy errors (apache#53004)

* Bump mypy to 1.16.1 and fix airflow-core mypy errors

* Bump mypy to 1.16.1 and fix airflow-core mypy errors

* remove mypy dep from additional_dependencies

* resolve comments
(cherry picked from commit bd38225)

Co-authored-by: GPK <[email protected]>
stephen-bracken pushed a commit to stephen-bracken/airflow that referenced this pull request Jul 15, 2025
…apache#53004)

* Bump mypy to 1.16.1 and fix airflow-core mypy errors

* Bump mypy to 1.16.1 and fix airflow-core mypy errors

* remove mypy dep from additional_dependencies

* resolve comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API area:dev-tools area:serialization backport-to-v3-0-test Mark PR with this label to backport to v3-0-test branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants