-
Notifications
You must be signed in to change notification settings - Fork 15.3k
Bump mypy to 1.16.1 for airflow-core and fix airflow-core mypy errors #53004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice - with one nit that mypy dependency is not needed/useful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, rest looks good
BTW i have not updated mypy version to 1.16.1 in devel-common on this PR, my plan is it update once all the fixes completed. that i am iterating with the #52997 will bump mypy version. |
446a070
to
c91d246
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking better, one comment @gopidesupavan
… mypy errors (#53004) * Bump mypy to 1.16.1 and fix airflow-core mypy errors * Bump mypy to 1.16.1 and fix airflow-core mypy errors * remove mypy dep from additional_dependencies * resolve comments (cherry picked from commit bd38225) Co-authored-by: GPK <[email protected]>
… mypy errors (apache#53004) * Bump mypy to 1.16.1 and fix airflow-core mypy errors * Bump mypy to 1.16.1 and fix airflow-core mypy errors * remove mypy dep from additional_dependencies * resolve comments (cherry picked from commit bd38225) Co-authored-by: GPK <[email protected]>
…apache#53004) * Bump mypy to 1.16.1 and fix airflow-core mypy errors * Bump mypy to 1.16.1 and fix airflow-core mypy errors * remove mypy dep from additional_dependencies * resolve comments
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in airflow-core/newsfragments.