-
Notifications
You must be signed in to change notification settings - Fork 15.2k
Add scrollTo buttons in TaskLogContent #51943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scrollTo buttons in TaskLogContent #51943
Conversation
For zh-TW translation, I use "捲動" instead of "滾動" due to official translation although I think the latter would be more common. Feel free to let me know if there is anything needing update or discussion. |
ad3c510
to
41220b9
Compare
airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogContent.tsx
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogContent.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogContent.tsx
Outdated
Show resolved
Hide resolved
41220b9
to
6f2b294
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think after my last test it looks good now... except that I found a small small nit that the hotkey given is "wrong" as it misses to mention the modifier you need to use. Can you adjust this? Then LGTM!
airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogContent.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks
Thanks! |
Thanks to YOU! |
Related Issue
#51788
(This PR would be helpful for the issue but not fix that issue)
Why
Most recent logs are the most important, which is at the end. It is painful to scroll to the end.
How
Screen.Recording.2025-06-20.at.1.45.24.AM.mov
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in airflow-core/newsfragments.