Skip to content

Add scrollTo buttons in TaskLogContent #51943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 23, 2025

Conversation

guan404ming
Copy link
Contributor

Related Issue

#51788
(This PR would be helpful for the issue but not fix that issue)

Why

Most recent logs are the most important, which is at the end. It is painful to scroll to the end.

How

  • add buttons with hot key to scroll to the end and to the begin
  • minor update: refactor log highlight with rowVirtualizer
Screen.Recording.2025-06-20.at.1.45.24.AM.mov

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@guan404ming
Copy link
Contributor Author

For zh-TW translation, I use "捲動" instead of "滾動" due to official translation although I think the latter would be more common. Feel free to let me know if there is anything needing update or discussion.

@guan404ming guan404ming force-pushed the refine-task-log-content branch from ad3c510 to 41220b9 Compare June 20, 2025 10:21
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good idea.

Button is overlapping the horizontal scroll bar:
Screenshot 2025-06-20 at 18 37 50

We should scroll a bit more, dynamic linking to a particular line, leave the line of interest outside of the view port, this is a link to line 59
Screenshot 2025-06-20 at 18 38 14

@guan404ming guan404ming force-pushed the refine-task-log-content branch from 41220b9 to 6f2b294 Compare June 22, 2025 08:41
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think after my last test it looks good now... except that I found a small small nit that the hotkey given is "wrong" as it misses to mention the modifier you need to use. Can you adjust this? Then LGTM!

@pierrejeambrun pierrejeambrun added this to the Airflow 3.1.0 milestone Jun 23, 2025
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@pierrejeambrun pierrejeambrun merged commit 2579bbf into apache:main Jun 23, 2025
50 checks passed
@guan404ming guan404ming deleted the refine-task-log-content branch June 23, 2025 16:00
@guan404ming
Copy link
Contributor Author

Thanks!

@jscheffl
Copy link
Contributor

Thanks!

Thanks to YOU!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants