Add endpoint to watch dag run until finish #51920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:API
|
FYI. Not sure if it helps but OpenAPI 3.2.0 will have support for |
uranusjr
force-pushed
the
stream-until-run-complete
branch
2 times, most recently
from
231597b to
007a051
Compare
|
I added some tests for the endpoint, but couldn’t figure out how to test the looping part. Hopefully this is good enough… |
uranusjr
requested review from
bbovenzi,
pierrejeambrun,
ryanahamilton,
jscheffl,
shubhamraj-git,
ephraimbuddy,
rawwar,
jason810496 and
bugraoz93
as code owners
airflow-core/src/airflow/api_fastapi/core_api/datamodels/dag_run.py
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/api_fastapi/core_api/routes/public/dag_run.py
Outdated
Show resolved
Hide resolved
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_dag_run.py
Show resolved
Hide resolved
jason810496
reviewed
Jun 27, 2025
airflow-core/src/airflow/api_fastapi/core_api/routes/public/dag_run.py
Outdated
Show resolved
Hide resolved
uranusjr
force-pushed
the
stream-until-run-complete
branch
from
007a051 to
152bd6d
Compare
pierrejeambrun
approved these changes
Jul 3, 2025
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_dag_run.py
Outdated
Show resolved
Hide resolved
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_dag_run.py
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/api_fastapi/core_api/openapi/v2-rest-api-generated.yaml
Show resolved
Hide resolved
uranusjr
force-pushed
the
stream-until-run-complete
branch
from
152bd6d to
34badc1
Compare
pierrejeambrun
approved these changes
Jul 7, 2025
uranusjr
force-pushed
the
stream-until-run-complete
branch
2 times, most recently
from
96812e6 to
422cd94
Compare
bugraoz93
approved these changes
Jul 7, 2025
kaxil
reviewed
Jul 7, 2025
airflow-core/src/airflow/api_fastapi/core_api/routes/public/dag_run.py
Outdated
Show resolved
Hide resolved
kaxil
approved these changes
Jul 7, 2025
There was a problem hiding this comment.
Some simple docs would be good. Fine as a follow-up too as long as we have a GH issue to not forget.
@vikramkoka could review that too
uranusjr
force-pushed
the
stream-until-run-complete
branch
from
422cd94 to
58d7fa5
Compare
1 task
|
Tracking doc addition #53067 |
HsiuChuanHsu
pushed a commit
to HsiuChuanHsu/airflow
that referenced
this pull request
Jul 10, 2025
stephen-bracken
pushed a commit
to stephen-bracken/airflow
that referenced
this pull request
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #51711.
I initially wanted to just enhance the trigger endpoint to optionally stream until the run finishes, but it seems that FastAPI does not like this optionally stream idea. You can do it of course, but would loose a lot of the auto annotation reflection feature. So I opted to have a separate streaming endpoint instead.
This endpoint repeatedly emits a JSON object at the specified interval, until the dag reaches a finished state.
Tests to come.