Navigate Grid view via keyboard #51784
Draft
+204
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyLee1224
requested review from
bbovenzi,
pierrejeambrun,
ryanahamilton,
jscheffl and
shubhamraj-git
as code owners
boring-cyborg
bot
added
area:translations
area:UI
Comment on lines
+57
to
+61
| const { search } = globalThis.location; | ||
| const searchParams = new URLSearchParams(search); | ||
| const groupPath = task.isGroup ? "group/" : ""; | ||
| const mappedPath = task.is_mapped ? "/mapped" : ""; | ||
| const path = `/dags/${dagId}/runs/${run.dag_run_id}/tasks/${groupPath}${task.id}${mappedPath}`; |
There was a problem hiding this comment.
This logic seems similar to what we have in TaskLink, maybe we can extract somme utility function and reuse it at both places to avoid inconsistencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
#31556
Overview
Users can now efficiently navigate, jump within task instances using only their keyboard, enhancing operational speed for power users. The core navigation is complete and ready for initial feedback.
This PR is currently a draft because the navigation functionality for the 'Runs'(columns) and 'Tasks'(rows) is still under development.
Screenshot
grid_nav.mp4
PS: The key presses you see on screen are from my recording app, not part of the UI itself! :)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.