Skip to content

Make notes in UI visible directly in header #51764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jscheffl
Copy link
Contributor

@jscheffl jscheffl commented Jun 15, 2025

In Airflow 2 Dag run and Task Instance notes were directly displayed in the details panel. In Airflow 3 UI you needed to click on the modal note button so far.

With this PR the notes are directly displayed on the header card for direct visibility... and can be edited. Button is only displayed to add the note initially.

This is according to the discussion in Slack: https://apache-airflow.slack.com/archives/C0809U4S1Q9/p1747945039343669

New experience on Dag run:

dag_run2-2025-06-15_18.01.23.mp4

New experience on Task instances:

task_instance-2025-06-15_18.07.00.mp4

FYI @AutomationDev85 @wolfdn @clellmann

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Jun 15, 2025
@jscheffl jscheffl added this to the Airflow 3.1.0 milestone Jun 15, 2025
@hussein-awala hussein-awala merged commit df38229 into apache:main Jun 15, 2025
44 checks passed
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a big fan of this change. If you have a 200 lines note. Everything will be push down and you'll have to scroll to access the rest of the UI.

@jscheffl
Copy link
Contributor Author

I am not a big fan of this change. If you have a 200 lines note. Everything will be push down and you'll have to scroll to access the rest of the UI.

Nobody forces you to have 200 lines of note. A note w/ markdown still could carry a <details> area which folds. Otherwise I doubt you can make a useful note with 200 lines if the note is limited to 1000 chars atm.

But otherwise: We could also wrap it into a box that has a maximum height of e.g. 200px so that you expand it only to full size if you click on it. Probably there is a component for this... feel free to add it.

@bbovenzi
Copy link
Contributor

bbovenzi commented Jun 16, 2025

Oh this will mess with the outstanding Gantt Chart PR so one of these needs to be rethought. I understand wanting to make notes more obvious. If so, we may need to do the same for dag and task documentation.

At the bare minimum, we should put this inside of an accordion so it can be hidden away.

Also, removing the "Add/Edit note" button form the header when there is a note isn't great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants