Skip to content

Update LanguageSelector to display flags #51560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

guan404ming
Copy link
Contributor

Why

It would be more straightforward for users to select language with flag shown
Thanks to @eladkal 's good idea

How

  • add flag property to each supportedLanguages entry
  • languageSelector uses flag from supportedLanguages for display
Screen.Recording.2025-06-10.at.11.24.38.AM.mov

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:translations area:UI Related to UI/UX. For Frontend Developers. labels Jun 10, 2025
@eladkal eladkal added this to the Airflow 3.1.0 milestone Jun 10, 2025
@eladkal eladkal added the type:misc/internal Changelog: Misc changes that should appear in change log label Jun 10, 2025
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes it's better to use svg flags instead of emojis which can appear differently depending on the browser and often feel less formal.

But we can start with this and improve later.

@pierrejeambrun pierrejeambrun merged commit 2862555 into apache:main Jun 10, 2025
46 checks passed
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:translations area:UI Related to UI/UX. For Frontend Developers. type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants