Ensure plurality in backfill count message with more than 1 run. #51541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tirkarthi
requested review from
bbovenzi,
pierrejeambrun,
ryanahamilton,
jscheffl and
shubhamraj-git
as code owners
jscheffl
approved these changes
Jun 9, 2025
bbovenzi
requested changes
Jun 9, 2025
airflow-core/src/airflow/ui/src/components/DagActions/inlineMessage.tsx
Outdated
Show resolved
Hide resolved
tirkarthi
force-pushed
the
fix-backfill-message
branch
from
6870b20 to
6289ea2
Compare
bbovenzi
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For backfill with more than 1 run "totalEntries > 1" becomes true and "1 run will be triggered" message is shown which is incorrect. This fixes the logic to show the message when there is 1 run and for more than 1 run the plural message will be shown