-
Notifications
You must be signed in to change notification settings - Fork 15.2k
Add is_rtl flag to supportedLanguages for RTL support (#51187) #51239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
{ code: "de", name: "Deutsch", is_rtl: "No" }, | ||
{ code: "en", name: "English", is_rtl: "No" }, | ||
{ code: "he", name: "עברית", is_rtl: "Yes" }, | ||
{ code: "ko", name: "한국어", is_rtl: "No" }, | ||
{ code: "nl", name: "Nederlands", is_rtl: "No" }, | ||
{ code: "pl", name: "Polski", is_rtl: "No" }, | ||
{ code: "zh-TW", name: "繁體中文", is_rtl: "No" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer we use a real boolean value of true
or false
instead of yes or no strings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
The goal of #51187 is also to implement the RTL support |
So this PR would "just" add the flag wO7 any functionality behind? Or is it WIP and the RTL logic will be pushed in a moment? I am asking because if the logic would come in a separate PR I'd favor to add the needed flags there. |
The logic to support RTL should be in this PR |
You could reference this doc to implement! Feel free to ask question if there is anything I could help. |
For not blocking rtl langs' translation for too long, I open another pr for handling the logic part #51376. |
Closing in favor of: |
Implements AIRFLOW-51187 by adding is_rtl flag to supportedLanguages in config.ts to support RTL languages like Hebrew. Language switcher not available in UI (depends on #51038), but flag is implemented. Most frontend tests passed; some unrelated failures due to test setup issues.
Fixes #51187.