Skip to content

Add is_rtl flag to supportedLanguages for RTL support (#51187) #51239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

UncoveredBread
Copy link

Implements AIRFLOW-51187 by adding is_rtl flag to supportedLanguages in config.ts to support RTL languages like Hebrew. Language switcher not available in UI (depends on #51038), but flag is implemented. Most frontend tests passed; some unrelated failures due to test setup issues.
Fixes #51187.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label May 30, 2025
Copy link

boring-cyborg bot commented May 30, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

Comment on lines +42 to +48
{ code: "de", name: "Deutsch", is_rtl: "No" },
{ code: "en", name: "English", is_rtl: "No" },
{ code: "he", name: "עברית", is_rtl: "Yes" },
{ code: "ko", name: "한국어", is_rtl: "No" },
{ code: "nl", name: "Nederlands", is_rtl: "No" },
{ code: "pl", name: "Polski", is_rtl: "No" },
{ code: "zh-TW", name: "繁體中文", is_rtl: "No" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer we use a real boolean value of true or false instead of yes or no strings

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@eladkal
Copy link
Contributor

eladkal commented May 30, 2025

The goal of #51187 is also to implement the RTL support

@jscheffl
Copy link
Contributor

The goal of #51187 is also to implement the RTL support

So this PR would "just" add the flag wO7 any functionality behind? Or is it WIP and the RTL logic will be pushed in a moment? I am asking because if the logic would come in a separate PR I'd favor to add the needed flags there.

@eladkal
Copy link
Contributor

eladkal commented Jun 1, 2025

I am asking because if the logic would come in a separate PR I'd favor to add the needed flags there.

The logic to support RTL should be in this PR

@guan404ming
Copy link
Contributor

guan404ming commented Jun 1, 2025

You could reference this doc to implement! Feel free to ask question if there is anything I could help.

@guan404ming
Copy link
Contributor

For not blocking rtl langs' translation for too long, I open another pr for handling the logic part #51376.

@pierrejeambrun
Copy link
Member

Closing in favor of:
#51376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support RTL for i18n
6 participants