Skip to content

Allow Asset decorator to work with any TaskFlow operator #51229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 23, 2025

Conversation

yoeo
Copy link
Contributor

@yoeo yoeo commented May 30, 2025

closes: #51228


Extends the Airflow 3 @asset decorator to support any TaskFlow operator.
To match the Asset-Centric Syntax specification, the asset is implicitly set as an outlet of the that task it decorates.

This is my first contribution here, I tried to keep the changes to a minimum but please let me know if there are any issues, and I will do my best to address them.

Thanks.


Examples usage (from #51228 ):

from airflow.sdk import asset, task


# Asset generated by a PythonOperator task with extra arguments
# The task `outlets` argument is implicitly set to `[secret_data]`
@asset(schedule="@daily")
@task(doc="Generate a secret number", retries=3)
def secret_data():
    return 42


# Asset generated by a BashOperator task (supports extra arguments as well)
# The task `outlets` argument is implicitly set to `[write_data]`
@asset(schedule=secret_data)
@task.bash()
def write_data(ti):
    random_number = ti.xcom_pull(
        dag_id="secret_data",
        task_ids="secret_data",
        key="return_value",
        include_prior_dates=True,
    )
    return f"echo {random_number}"

image

Copy link

boring-cyborg bot commented May 30, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@yoeo yoeo force-pushed the main branch 2 times, most recently from 5b011ef to 37479ee Compare June 6, 2025 14:18
@yoeo yoeo requested a review from uranusjr June 9, 2025 16:54
@yoeo yoeo force-pushed the main branch 2 times, most recently from 09e0011 to c54ac9f Compare June 14, 2025 07:51
@uranusjr uranusjr added this to the Airflow 3.1.0 milestone Jun 15, 2025
@Lee-W
Copy link
Member

Lee-W commented Jun 19, 2025

the test failure doesn't look like something related to this change. let me rebase from the main branch and see how it works

@Lee-W Lee-W force-pushed the main branch 2 times, most recently from 151cfcb to d9539ea Compare June 21, 2025 06:23
@uranusjr uranusjr merged commit fab3d5a into apache:main Jun 23, 2025
72 checks passed
Copy link

boring-cyborg bot commented Jun 23, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Asset Decorator to Work with Any TaskFlow Operator
3 participants