i18n: Replaced hard-coded "no {modelName} found" message in DataTable #51209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyLee1224
requested review from
Lee-W,
bbovenzi,
pierrejeambrun,
ryanahamilton,
jscheffl and
shubhamraj-git
as code owners
jscheffl
approved these changes
May 29, 2025
bbovenzi
approved these changes
May 29, 2025
|
i18n changes are happening so fast! we already have merge conflicts |
Lee-W
reviewed
May 30, 2025
There was a problem hiding this comment.
Late to the party but thanks @RoyLee1224 ! One nitpick, I'll send a PR for it
| "docs": "文件", | ||
| "home": "首頁", | ||
| "plugins": "插件" | ||
| "plugins": "插件", |
There was a problem hiding this comment.
This looks wrong. Missed this one. Let me send a new PR for it 🤔
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
…apache#51209) * fix:replace hard-coded noRowMessage in DataTable * fix:remove unnecessary count * add back noRowMessage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why introduce
noItemsFoundas an improved default fallbackFor pages that currently lack a customized noRowsMessage, DataTable will now display a fully translated message.
For example, instead of an erroneous "No 任務實例 found" (a mix of English and Chinese), the UI will correctly render a message like "找不到任務實例".
Why is the
noRowsMessageprop still crucialRelying solely on this generic template with modelName interpolation is insufficient due to complex grammatical rules in some languages. For example:
Therefore, the long-term goal is to increasingly utilize the
noRowsMessageprop to provide fully tailored messages.Additional information
For more information on such practices, please refer to:
i18n Best Practices for Front-End Developers
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.