Emit mouse changes on panning event #166
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry have additional changes to make, just going to add a method to the api |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a unique use case where we had two separate images that we had to pan and zoom in unison.
Zooming worked fine as we were able to pass the clientX and clientY through an event hub to the sibling component and call zoomAbs(clientx, clienty).
However, when panning we needed access dx and dy so we could also pass them through an event hub and call moveTo(dx, dy) on the sibling component. Currently the api did not have any way to emit the actual mouse event when panning.
This might open the door for further changes to expose mouse movements along with the api on the instances that are listened for.