New function smoothZoomAbs that uses an absolute zoom value #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 2, 2019 19:56
… of a relative one. (cherry picked from commit b92884b)
…re-request-smoothZoomToAbs # Conflicts: # dist/panzoom.min.js
anvaka
reviewed
Sep 8, 2019
dist/panzoom.js
Outdated
| @@ -115,6 +115,7 @@ function createPanZoom(domElement, options) { | |||
| zoomTo: publicZoomTo, | |||
| zoomAbs: zoomAbs, | |||
| smoothZoom: smoothZoom, | |||
| smoothZoomToAbs: smoothZoomToAbs, | |||
There was a problem hiding this comment.
Can we change this to smoothZoomAbs() so that it is symmetrical to zoomAbs()?
There was a problem hiding this comment.
Sure, I've committed an update.
… existing functions.
TimoKunze
changed the title
|
Thank you! Published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had the use case where I needed smooth scrolling with absolute zoom factors. I did not find a solution using the existing panzoom features, so I implemented a new function smoothZoomToAbs.