Skip to content

Add option to disable text selection prevention #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 10, 2019
Merged

Add option to disable text selection prevention #121

merged 4 commits into from
Sep 10, 2019

Conversation

graphman65
Copy link
Contributor

Hi,
The default behavior is that panzoom disable text selection inside the panned component.
This means you cannot focus input inside the component.

I added an option to remove this default behavior.

@anvaka
Copy link
Owner

anvaka commented Sep 7, 2019

Hi @graphman65

Thank you for this PR. I was curious if you could inverse the option? E.g. call it enableTextSelection?

Main reason for this is that it's easier to read negations of positive statement vs negation of the negative statement. Here are couple more articles with in-depth reasoning:

@graphman65 graphman65 closed this Sep 9, 2019
@graphman65 graphman65 reopened this Sep 9, 2019
@graphman65
Copy link
Contributor Author

Hi @anvaka

Thanks for the review. Here is the updated code.

@anvaka anvaka merged commit e29fe62 into anvaka:master Sep 10, 2019
@anvaka
Copy link
Owner

anvaka commented Sep 10, 2019

Thank you! Published as v8.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants