Fix missing path parameters when also adding headers #216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mitmproxy2swagger adds path parameters like
/{id}
correctly asWhen using
mitmproxy2swagger --headers
the headers are added, but the parameters will be missing:The correct result should be
The reason for this bug is that if
args.headers
is used, the keyparameters
inswagger
is already set and the laterset_key_if_not_exists
forparams
does not extend the keyparameters
.One (least invasive) fix is to merge both arrays.