Add sampling to flow heuristic. #215
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request solves the issue of mitmproxy dump files (flows) getting interpreted to be
.harfiles bydetect_input_format(). The error I have been seeing is:The proposed solution should solve a lot of issues where inserting
-f flowmakes the program run properly. For example #213, #171, and likely #214.Root cause
Enabling the debugging mode by setting the
MITMPROXY2SWAGGER_DEBUGenvironment variable revealed that the heuristics generated indetect_input_format()was higher for.hareven though the file was a flow dump. The main heuristic for detecting flow files is non-printable (ascii) characters. The underlying issue is thatmitmproxy_dump_file_huristic()assumes these will be present in the first 2048 bytes. In my case these were filled with certificates, containing purely printable characters, causing a miss in the heuristic.Proposed solution
Instead of relying on the first 2048 bytes, sample throughout the file for non-printables.