Extending and streamlining #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anifests. \nStreamlining redundant logic on register.pp. \nIncluding init in type. \nAdding ability to specify header template.
alkivi-sas
pushed a commit
that referenced
this pull request
Nov 23, 2014
Extending and streamlining
|
Forge updated ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
We were looking for a module that implemented R.I.Pienaar's classic motd concat example rather than creating yet other instance of this. Your's was closest.
I've added some comments, tidied up a little logic in the type, fixed the fact that ordering was not passed through to concat and added the ability to define a custom template in the header.
How about updating your module on the forge?