-
-
Notifications
You must be signed in to change notification settings - Fork 79
feat(channels): Channel for Justfile recipes #691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I also added a line in my
In accordance with the contribution guidelines this line is not added to this PR. |
command = ["just --summary | tr '[:blank:]' '\n'"] | ||
|
||
[preview] | ||
command = "just -s {}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about running the selection on completion?
[metadata]
name = "just-recipes"
description = "A channel to select recipes from Justfiles"
requirements = ["just"]
[source]
command = ["just --summary | tr '[:blank:]' '\n'"]
[preview]
command = "just -s {}"
[keybindings]
enter = "actions:execute-recipe"
[actions.execute-recipe]
description = "Execute a justfile recipe"
command = "just {}"
mode = "execute"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fast review and the suggestion.
I would prefer a different keybind than enter
, for example ctrl-x
for execute, because my usual workflow is using ctrl-t
for command-line completion. The proposed action is conflicting in that case and may give unintended console output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! That makes sense, let's make the change and merge this :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already made the change.
Thanks again. I like this tool!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah nice, alright let's merge this 🎉
Thanks 🙏
Thanks so much for the contribution! Added a small suggestion, tell me what you think 😊 |
📺 PR Description
Add a channel to select and preview recipes from a Justfile
Checklist