UI: Optional scrollbar and mouse support for the preview panel

[lalvarezt]

cleaned up keybinding section from config

@alexpasmantier you had this code before, perhaps there was a reason for it?

        if cfg!(not(windows)) {
            execute!(buffered_stderr, DisableMouseCapture)?;
        }

[alexpasmantier]

Looks like this was related to #338 which was solved in #348 and it seems disabling mouse capture in windows caused a crash. But my memory is foggy on that one 😬

[lalvarezt]

just tested it on windows and mouse scrolling works

[alexpasmantier]

Can't seem to get mouse scrolling working on my machine 🤔 Is there anything in particular I need to do or should it just work out of the box?

[lalvarezt]

Can't seem to get mouse scrolling working on my machine 🤔 Is there anything in particular I need to do or should it just work out of the box?

the config lines are commented, I left it as opt in. just swap them

scroll_preview_half_page_down = ["ctrl-d"]
scroll_preview_half_page_up = ["ctrl-u"]  # CONFLICT: Ctrl+u is hardcoded for delete line
#scroll_preview_half_page_down = ["ctrl-d", "mousescrolldown"]  # Optional mouse support
#scroll_preview_half_page_up = ["ctrl-u", "mousescrollup"]  # Optional mouse support

[alexpasmantier]

Ahhh my bad, thanks! need a bit more coffee 🫠

[alexpasmantier]

Works perfectly 👍🏻

I think this should be enabled by default instead of being an opt-in.

[alexpasmantier]

Very nice! Great work 👍🏻

[raylu]

it seems like EnableMouseCapture gets called unconditionally
would you be open to adding a config flag to disable this feature? (I like to copy from the ctrl+r/history search and ctrl+y currently copies the whole histfile line)